Fix swiftIdentifier crash with empty strings
#105
Conversation
| @@ -114,10 +114,10 @@ enum SwiftIdentifier { | |||
| static func prefixWithUnderscoreIfNeeded(string: String, | |||
| forbiddenChars exceptions: String = "") -> String { | |||
|
|
|||
| let (head, _) = identifierCharacterSets(exceptions: exceptions) | |||
| guard let firstChar = string.unicodeScalars.first, | |||
| !string.isEmpty else { return "" } | |||
There was a problem hiding this comment.
string.isEmpty can't ever be false if string.unicodeScalars.first is not nil, right? If string is empty, then string.unocodeScalars.first will return nil and already make the condition fail anyway
There was a problem hiding this comment.
You'd think so, wouldn't you? Give it a try, for some absolutely bizarre reason, the isEmpty check is needed 🤷♂️
There was a problem hiding this comment.
Wait seriously?
isEmpty checks on characters, unicodeScalars is different, so that could make sense, maybe… but can't see an example
Do you mean that if we don't test isEmpty, the test on "" fails?
There was a problem hiding this comment.
It throws an exception (SIGINT or something I think)
There was a problem hiding this comment.
Just tested by cloning your branch and removing that !string.isEmpty in the condition and all test passed successfully, without SIGINT?
djbe
force-pushed
the
fix/swift-identifier
branch
from
3fc3f51 to
772fdc3
Compare
djbe
force-pushed
the
fix/swift-identifier
branch
from
772fdc3 to
6a981aa
Compare
Fixes SwiftGen/SwiftGen#528.